llvy.ltd/casdoor
1
0
Fork 0
mirror of https://github.com/casdoor/casdoor.git synced 2025-09-09 00:42:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: check the duplicated Application ClientId (#1481)

Browse Source 
* fix: Check the duplicate ClientId and ClientSecret of Application.

* Bug fix
This commit is contained in:
buptxxb65
2023-01-17 17:37:20 +08:00
committed by GitHub
parent 79fc0516dd
commit 0021226a60
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
object/application.go
View File

@@ -287,7 +287,8 @@ func GetMaskedApplications(applications []*Application, userId string) []*Applic
func UpdateApplication(id string, application *Application) bool { func UpdateApplication(id string, application *Application) bool {
owner, name := util.GetOwnerAndNameFromId(id) owner, name := util.GetOwnerAndNameFromId(id)
if getApplication(owner, name) == nil { oldApplication := getApplication(owner, name)
if oldApplication == nil {
return false return false
} }
@@ -302,6 +303,10 @@ func UpdateApplication(id string, application *Application) bool {
} }
} }
if oldApplication.ClientId != application.ClientId && GetApplicationByClientId(application.ClientId) != nil {
return false
}
for _, providerItem := range application.Providers { for _, providerItem := range application.Providers {
providerItem.Provider = nil providerItem.Provider = nil
} }
@@ -325,6 +330,9 @@ func AddApplication(application *Application) bool {
if application.ClientSecret == "" { if application.ClientSecret == "" {
application.ClientSecret = util.GenerateClientSecret() application.ClientSecret = util.GenerateClientSecret()
} }
if GetApplicationByClientId(application.ClientId) != nil {
return false
}
for _, providerItem := range application.Providers { for _, providerItem := range application.Providers {
providerItem.Provider = nil providerItem.Provider = nil
} }