From 095659b7649504ce872f4378e5a4e594705da124 Mon Sep 17 00:00:00 2001 From: okatu-loli Date: Tue, 24 Sep 2024 18:28:37 +0800 Subject: [PATCH] feat: Simplify gender and info checks using includes --- web/src/auth/SignupPage.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/web/src/auth/SignupPage.js b/web/src/auth/SignupPage.js index 75574628..a8f6231c 100644 --- a/web/src/auth/SignupPage.js +++ b/web/src/auth/SignupPage.js @@ -286,6 +286,7 @@ class SignupPage extends React.Component { } renderFormItem(application, signupItem) { + const validItems = ["Gender", "Bio", "Tag", "Education"]; if (!signupItem.visible) { return null; } @@ -723,15 +724,8 @@ class SignupPage extends React.Component { ); }) - ); - } else if (signupItem.name === "Gender") { - return renderFormItem(signupItem); - } else if (signupItem.name === "Bio") { - return renderFormItem(signupItem); - } else if (signupItem.name === "Tag") { - return renderFormItem(signupItem); - } else if (signupItem.name === "Education") { + } else if (validItems.includes(signupItem.name)) { return renderFormItem(signupItem); } }