diff --git a/controllers/organization.go b/controllers/organization.go index a42a0cb3..99bb1618 100644 --- a/controllers/organization.go +++ b/controllers/organization.go @@ -133,11 +133,12 @@ func (c *ApiController) GetDefaultApplication() { userId := c.GetSessionUsername() id := c.Input().Get("id") - application := object.GetMaskedApplication(object.GetDefaultApplication(id), userId) - if application == nil { - c.ResponseError("Please set a default application for this organization") + application, err := object.GetDefaultApplication(id) + if err != nil { + c.ResponseError(err.Error()) return } - c.ResponseOk(application) + maskedApplication := object.GetMaskedApplication(application, userId) + c.ResponseOk(maskedApplication) } diff --git a/object/organization.go b/object/organization.go index 0f36ac16..c5b4b198 100644 --- a/object/organization.go +++ b/object/organization.go @@ -218,14 +218,14 @@ func CheckAccountItemModifyRule(accountItem *AccountItem, user *User) (bool, str return true, "" } -func GetDefaultApplication(id string) *Application { +func GetDefaultApplication(id string) (*Application, error) { organization := GetOrganization(id) if organization == nil { - return nil + return nil, fmt.Errorf("The organization: %s does not exist", id) } if organization.DefaultApplication != "" { - return getApplication("admin", organization.DefaultApplication) + return getApplication("admin", organization.DefaultApplication), fmt.Errorf("The default application: %s does not exist", organization.DefaultApplication) } applications := []*Application{} @@ -235,7 +235,7 @@ func GetDefaultApplication(id string) *Application { } if len(applications) == 0 { - return nil + return nil, fmt.Errorf("The application does not exist") } defaultApplication := applications[0] @@ -249,5 +249,5 @@ func GetDefaultApplication(id string) *Application { extendApplicationWithProviders(defaultApplication) extendApplicationWithOrg(defaultApplication) - return defaultApplication + return defaultApplication, nil }