Improve adapter.UseSameDb

This commit is contained in:
Yang Luo 2023-09-26 23:40:51 +08:00
parent 1319216625
commit 56787fab90
4 changed files with 118 additions and 90 deletions

View File

@ -30,6 +30,7 @@ type Adapter struct {
Name string `xorm:"varchar(100) notnull pk" json:"name"`
CreatedTime string `xorm:"varchar(100)" json:"createdTime"`
Table string `xorm:"varchar(100)" json:"table"`
UseSameDb bool `json:"useSameDb"`
Type string `xorm:"varchar(100)" json:"type"`
DatabaseType string `xorm:"varchar(100)" json:"databaseType"`
@ -38,8 +39,6 @@ type Adapter struct {
User string `xorm:"varchar(100)" json:"user"`
Password string `xorm:"varchar(100)" json:"password"`
Database string `xorm:"varchar(100)" json:"database"`
Table string `xorm:"varchar(100)" json:"table"`
TableNamePrefix string `xorm:"varchar(100)" json:"tableNamePrefix"`
*xormadapter.Adapter `xorm:"-" json:"-"`
}
@ -140,25 +139,22 @@ func (adapter *Adapter) GetId() string {
return fmt.Sprintf("%s/%s", adapter.Owner, adapter.Name)
}
func (adapter *Adapter) getTable() string {
if adapter.DatabaseType == "mssql" {
return fmt.Sprintf("[%s]", adapter.Table)
} else {
return adapter.Table
}
}
func (adapter *Adapter) InitAdapter() error {
if adapter.Adapter == nil {
var dataSourceName string
if adapter.Adapter != nil {
return nil
}
var driverName string
var dataSourceName string
if adapter.UseSameDb || adapter.isBuiltIn() {
driverName = conf.GetConfigString("driverName")
dataSourceName = conf.GetConfigString("dataSourceName")
if adapter.DatabaseType == "mysql" {
dataSourceName = dataSourceName + adapter.Database
if conf.GetConfigString("driverName") == "mysql" {
dataSourceName = dataSourceName + conf.GetConfigString("dbName")
}
} else {
switch adapter.DatabaseType {
driverName = adapter.DatabaseType
switch driverName {
case "mssql":
dataSourceName = fmt.Sprintf("sqlserver://%s:%s@%s:%d?database=%s", adapter.User,
adapter.Password, adapter.Host, adapter.Port, adapter.Database)
@ -182,21 +178,30 @@ func (adapter *Adapter) InitAdapter() error {
dataSourceName = strings.ReplaceAll(dataSourceName, "dbi.", "db.")
}
var err error
engine, err := xorm.NewEngine(adapter.DatabaseType, dataSourceName)
engine, err := xorm.NewEngine(driverName, dataSourceName)
if err != nil {
return err
}
if (adapter.UseSameDb || adapter.isBuiltIn()) && adapter.DatabaseType == "postgres" {
if (adapter.UseSameDb || adapter.isBuiltIn()) && driverName == "postgres" {
schema := util.GetValueFromDataSourceName("search_path", dataSourceName)
if schema != "" {
engine.SetSchema(schema)
}
}
adapter.Adapter, err = xormadapter.NewAdapterByEngineWithTableName(engine, adapter.getTable(), adapter.TableNamePrefix)
var tableName string
if driverName == "mssql" {
tableName = fmt.Sprintf("[%s]", adapter.Table)
} else {
tableName = adapter.Table
}
adapter.Adapter, err = xormadapter.NewAdapterByEngineWithTableName(engine, tableName, "")
if err != nil {
return err
}
}
return nil
}

View File

@ -426,8 +426,8 @@ func initBuiltInUserAdapter() {
Owner: "built-in",
Name: "user-adapter-built-in",
CreatedTime: util.GetCurrentTime(),
UseSameDb: true,
Table: "casbin_user_rule",
UseSameDb: true,
}
_, err = AddAdapter(adapter)
if err != nil {
@ -449,8 +449,8 @@ func initBuiltInApiAdapter() {
Owner: "built-in",
Name: "api-adapter-built-in",
CreatedTime: util.GetCurrentTime(),
UseSameDb: true,
Table: "casbin_api_rule",
UseSameDb: true,
}
_, err = AddAdapter(adapter)
if err != nil {

View File

@ -115,6 +115,17 @@ class AdapterEditPage extends React.Component {
}} />
</Col>
</Row>
<Row style={{marginTop: "20px"}} >
<Col style={{marginTop: "5px"}} span={(Setting.isMobile()) ? 22 : 2}>
{Setting.getLabel(i18next.t("syncer:Table"), i18next.t("syncer:Table - Tooltip"))} :
</Col>
<Col span={22} >
<Input value={this.state.adapter.table}
disabled={Setting.builtInObject(this.state.adapter)} onChange={e => {
this.updateAdapterField("table", e.target.value);
}} />
</Col>
</Row>
<Row style={{marginTop: "20px"}} >
<Col style={{marginTop: "5px"}} span={(Setting.isMobile()) ? 19 : 2}>
{Setting.getLabel(i18next.t("adapter:Use same DB"), i18next.t("adapter:Use same DB - Tooltip"))} :
@ -122,6 +133,23 @@ class AdapterEditPage extends React.Component {
<Col span={1} >
<Switch disabled={Setting.builtInObject(this.state.adapter)} checked={this.state.adapter.useSameDb || Setting.builtInObject(this.state.adapter)} onChange={checked => {
this.updateAdapterField("useSameDb", checked);
if (checked) {
this.updateAdapterField("type", "");
this.updateAdapterField("databaseType", "");
this.updateAdapterField("host", "");
this.updateAdapterField("port", 0);
this.updateAdapterField("user", "");
this.updateAdapterField("password", "");
this.updateAdapterField("database", "");
} else {
this.updateAdapterField("type", "Database");
this.updateAdapterField("databaseType", "mysql");
this.updateAdapterField("host", "localhost");
this.updateAdapterField("port", 3306);
this.updateAdapterField("user", "root");
this.updateAdapterField("password", "123456");
this.updateAdapterField("database", "dbName");
}
}} />
</Col>
</Row>
@ -219,17 +247,6 @@ class AdapterEditPage extends React.Component {
</React.Fragment>
)
}
<Row style={{marginTop: "20px"}} >
<Col style={{marginTop: "5px"}} span={(Setting.isMobile()) ? 22 : 2}>
{Setting.getLabel(i18next.t("syncer:Table"), i18next.t("syncer:Table - Tooltip"))} :
</Col>
<Col span={22} >
<Input value={this.state.adapter.table}
disabled={Setting.builtInObject(this.state.adapter)} onChange={e => {
this.updateAdapterField("table", e.target.value);
}} />
</Col>
</Row>
<Row style={{marginTop: "20px"}} >
<Col style={{marginTop: "5px"}} span={(Setting.isMobile()) ? 22 : 2}>
{Setting.getLabel(i18next.t("provider:DB test"), i18next.t("provider:DB test - Tooltip"))} :

View File

@ -14,7 +14,7 @@
import React from "react";
import {Link} from "react-router-dom";
import {Button, Table} from "antd";
import {Button, Switch, Table} from "antd";
import moment from "moment";
import * as Setting from "./Setting";
import * as AdapterBackend from "./backend/AdapterBackend";
@ -30,14 +30,8 @@ class AdapterListPage extends BaseListPage {
owner: owner,
name: `adapter_${randomName}`,
createdTime: moment().format(),
type: "Database",
host: "localhost",
port: 3306,
user: "root",
password: "123456",
databaseType: "mysql",
database: "dbName",
table: "tableName",
useSameDb: true,
};
}
@ -118,6 +112,25 @@ class AdapterListPage extends BaseListPage {
return Setting.getFormattedDate(text);
},
},
{
title: i18next.t("syncer:Table"),
dataIndex: "table",
key: "table",
width: "120px",
sorter: true,
},
{
title: i18next.t("adapter:Use same DB"),
dataIndex: "useSameDb",
key: "useSameDb",
width: "120px",
sorter: true,
render: (text, record, index) => {
return (
<Switch disabled checkedChildren="ON" unCheckedChildren="OFF" checked={text} />
);
},
},
{
title: i18next.t("provider:Type"),
dataIndex: "type",
@ -181,13 +194,6 @@ class AdapterListPage extends BaseListPage {
width: "120px",
sorter: true,
},
{
title: i18next.t("syncer:Table"),
dataIndex: "table",
key: "table",
width: "120px",
sorter: true,
},
{
title: i18next.t("general:Action"),
dataIndex: "",