feat: Users added through LDAP cannot log in using the set password (#3175)

* fix: login will prioritize the use of password set in casdoor and use ldap when use LDAP option in login form or user never change their password in casdoor after sync

* fix: promote if statement
This commit is contained in:
DacongDA 2024-09-06 10:31:34 +08:00 committed by GitHub
parent 05bfd3a3a3
commit 973a1df6c2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -354,8 +354,8 @@ func CheckUserPassword(organization string, username string, password string, la
} }
} }
if user.Ldap != "" { if user.Ldap != "" && (isSigninViaLdap || user.Password == "") {
if !isSigninViaLdap && !isPasswordWithLdapEnabled { if !isPasswordWithLdapEnabled {
return nil, fmt.Errorf(i18n.Translate(lang, "check:password or code is incorrect")) return nil, fmt.Errorf(i18n.Translate(lang, "check:password or code is incorrect"))
} }