From e0d9cc7ed1f7377dd2b7d58cf0b52ca4fd195391 Mon Sep 17 00:00:00 2001 From: DacongDA Date: Sun, 3 Aug 2025 01:26:18 +0800 Subject: [PATCH] feat: improve error handling on signInWithWebAuthn (#4033) --- web/src/auth/LoginPage.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/web/src/auth/LoginPage.js b/web/src/auth/LoginPage.js index d692504a..5532b27f 100644 --- a/web/src/auth/LoginPage.js +++ b/web/src/auth/LoginPage.js @@ -1109,8 +1109,7 @@ class LoginPage extends React.Component { .then(res => res.json()) .then((credentialRequestOptions) => { if ("status" in credentialRequestOptions) { - Setting.showMessage("error", credentialRequestOptions.msg); - throw credentialRequestOptions.status.msg; + return Promise.reject(new Error(credentialRequestOptions.msg)); } credentialRequestOptions.publicKey.challenge = UserWebauthnBackend.webAuthnBufferDecode(credentialRequestOptions.publicKey.challenge); @@ -1169,7 +1168,7 @@ class LoginPage extends React.Component { Setting.showMessage("error", `${i18next.t("general:Failed to connect to server")}${error}`); }); }).catch(error => { - Setting.showMessage("error", `${error}`); + Setting.showMessage("error", `${error.message}`); }).finally(() => { this.setState({ loginLoading: false,