llvy.ltd/casdoor
1
0
Fork 0
mirror of https://github.com/casdoor/casdoor.git synced 2025-05-23 02:35:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: fix bug that GitHub oauth provider shows error if failed to fetch user's email (#3474)

Browse Source 
* fix: fix github idp will stop login if it cannot fetch user's email through al restful api

* Update github.go

---------

Co-authored-by: hsluoyz <hsluoyz@qq.com>
This commit is contained in:
DacongDA 2025-01-05 20:25:42 +08:00 committed by GitHub
parent e5a2057382
commit e27c764a55
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
idp/github.go
View File

@ -248,16 +248,17 @@ func (idp *GithubIdProvider) GetUserInfo(token *oauth2.Token) (*UserInfo, error)
if err != nil { if err != nil {
return nil, err return nil, err
} }
return nil, fmt.Errorf("%s, %s", errMessage.Message, errMessage.DocumentationUrl)
}
var userEmails []GitHubUserEmailInfo fmt.Printf("GithubIdProvider:GetUserInfo() error, status code = %d, error message = %v\n", respEmail.StatusCode, errMessage)
err = json.Unmarshal(emailBody, &userEmails) } else {
if err != nil { var userEmails []GitHubUserEmailInfo
return nil, err err = json.Unmarshal(emailBody, &userEmails)
} if err != nil {
return nil, err
}
githubUserInfo.Email = idp.getEmailFromEmailsResult(userEmails) githubUserInfo.Email = idp.getEmailFromEmailsResult(userEmails)
}
} }
userInfo := UserInfo{ userInfo := UserInfo{