From ec5a574ce6f221ecf096c40548ef7aabcbad87ac Mon Sep 17 00:00:00 2001
From: Yang Luo <hsluoyz@qq.com>
Date: Sun, 6 Jun 2021 11:17:37 +0800
Subject: [PATCH] Show null provider error.

---
 controllers/auth.go | 7 +++++++
 idp/facebook.go     | 1 -
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/controllers/auth.go b/controllers/auth.go
index e0487bd9..ece7de7a 100644
--- a/controllers/auth.go
+++ b/controllers/auth.go
@@ -177,6 +177,13 @@ func (c *ApiController) Login() {
 		provider := object.GetProvider(fmt.Sprintf("admin/%s", form.Provider))
 
 		idProvider := idp.GetIdProvider(provider.Type, provider.ClientId, provider.ClientSecret, form.RedirectUri)
+		if idProvider == nil {
+			resp = &Response{Status: "error", Msg: fmt.Sprintf("provider: %s does not exist", provider.Type)}
+			c.Data["json"] = resp
+			c.ServeJSON()
+			return
+		}
+
 		idProvider.SetHttpClient(httpClient)
 
 		if form.State != beego.AppConfig.String("authState") && form.State != application.Name {
diff --git a/idp/facebook.go b/idp/facebook.go
index d3c896a1..a4feb82a 100644
--- a/idp/facebook.go
+++ b/idp/facebook.go
@@ -164,7 +164,6 @@ func (idp *FacebookIdProvider) GetUserInfo(token *oauth2.Token) (*UserInfo, erro
 
 	userInfo := UserInfo{
 		Id:          facebookUserInfo.Id,
-		Username:    facebookUserInfo.Id,
 		DisplayName: facebookUserInfo.Name,
 		Email:       facebookUserInfo.Email,
 		AvatarUrl:   facebookUserInfo.Picture.Data.Url,