mirror of
https://github.com/casdoor/casdoor.git
synced 2025-09-08 04:00:51 +08:00
feat: Fix GetFilteredPoliciesMulti when filtering only by ptype (#4039)
This commit is contained in:
@@ -16,6 +16,7 @@ package object
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"slices"
|
||||||
|
|
||||||
"github.com/casbin/casbin/v2"
|
"github.com/casbin/casbin/v2"
|
||||||
"github.com/casdoor/casdoor/util"
|
"github.com/casdoor/casdoor/util"
|
||||||
@@ -209,7 +210,7 @@ func GetPolicies(id string) ([]*xormadapter.CasbinRule, error) {
|
|||||||
// Filter represents filter criteria with optional policy type
|
// Filter represents filter criteria with optional policy type
|
||||||
type Filter struct {
|
type Filter struct {
|
||||||
Ptype string `json:"ptype,omitempty"`
|
Ptype string `json:"ptype,omitempty"`
|
||||||
FieldIndex int `json:"fieldIndex"`
|
FieldIndex *int `json:"fieldIndex,omitempty"`
|
||||||
FieldValues []string `json:"fieldValues"`
|
FieldValues []string `json:"fieldValues"`
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -262,24 +263,29 @@ func GetFilteredPoliciesMulti(id string, filters []Filter) ([]*xormadapter.Casbi
|
|||||||
for _, policy := range allPolicies {
|
for _, policy := range allPolicies {
|
||||||
matchesAllFilters := true
|
matchesAllFilters := true
|
||||||
for _, filter := range filters {
|
for _, filter := range filters {
|
||||||
// If no policy type is specified, set it to the default policy type
|
// Default policy type if unspecified
|
||||||
if filter.Ptype == "" {
|
if filter.Ptype == "" {
|
||||||
filter.Ptype = "p"
|
filter.Ptype = "p"
|
||||||
}
|
}
|
||||||
// Check policy type
|
// Always check policy type
|
||||||
if policy.Ptype != filter.Ptype {
|
if policy.Ptype != filter.Ptype {
|
||||||
matchesAllFilters = false
|
matchesAllFilters = false
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check if field index is valid (0-5 for V0-V5)
|
// If FieldIndex is nil, only filter via ptype (skip field-value checks)
|
||||||
if filter.FieldIndex < 0 || filter.FieldIndex > 5 {
|
if filter.FieldIndex == nil {
|
||||||
matchesAllFilters = false
|
continue
|
||||||
break
|
|
||||||
}
|
}
|
||||||
|
|
||||||
fieldValue := ""
|
fieldIndex := *filter.FieldIndex
|
||||||
switch filter.FieldIndex {
|
// If FieldIndex is out of range, also only filter via ptype
|
||||||
|
if fieldIndex < 0 || fieldIndex > 5 {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
var fieldValue string
|
||||||
|
switch fieldIndex {
|
||||||
case 0:
|
case 0:
|
||||||
fieldValue = policy.V0
|
fieldValue = policy.V0
|
||||||
case 1:
|
case 1:
|
||||||
@@ -294,15 +300,8 @@ func GetFilteredPoliciesMulti(id string, filters []Filter) ([]*xormadapter.Casbi
|
|||||||
fieldValue = policy.V5
|
fieldValue = policy.V5
|
||||||
}
|
}
|
||||||
|
|
||||||
found := false
|
// When FieldIndex is provided and valid, enforce FieldValues (if any)
|
||||||
// Check if field value is in the list of expected values
|
if len(filter.FieldValues) > 0 && !slices.Contains(filter.FieldValues, fieldValue) {
|
||||||
for _, expectedValue := range filter.FieldValues {
|
|
||||||
if fieldValue == expectedValue {
|
|
||||||
found = true
|
|
||||||
break
|
|
||||||
}
|
|
||||||
}
|
|
||||||
if !found {
|
|
||||||
matchesAllFilters = false
|
matchesAllFilters = false
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user