llvy.ltd/casdoor
1
0
Fork 0
mirror of https://github.com/casdoor/casdoor.git synced 2025-05-23 10:45:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: don't drop empty table for adapters (#3043)

Browse Source 
* fix: solve the problem of update operation returning 'unaffected'

* feat: remove the action for Dropping empty adapter data table
This commit is contained in:
赵尧鹏 2024-07-09 11:35:22 +08:00 committed by GitHub
parent 52cc2e4fa7
commit cad2e1bcc3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
object/permission.go
View File

@ -181,15 +181,15 @@ func UpdatePermission(id string, permission *Permission) (bool, error) {
return false, err
}
if oldPermission.Adapter != "" && oldPermission.Adapter != permission.Adapter {
isEmpty, _ := ormer.Engine.IsTableEmpty(oldPermission.Adapter)
if isEmpty {
err = ormer.Engine.DropTables(oldPermission.Adapter)
if err != nil {
return false, err
}
}
}
// if oldPermission.Adapter != "" && oldPermission.Adapter != permission.Adapter {
// isEmpty, _ := ormer.Engine.IsTableEmpty(oldPermission.Adapter)
// if isEmpty {
// err = ormer.Engine.DropTables(oldPermission.Adapter)
// if err != nil {
// return false, err
// }
// }
// }
err = addGroupingPolicies(permission)
if err != nil {
@ -312,15 +312,15 @@ func DeletePermission(permission *Permission) (bool, error) {
return false, err
}
if permission.Adapter != "" && permission.Adapter != "permission_rule" {
isEmpty, _ := ormer.Engine.IsTableEmpty(permission.Adapter)
if isEmpty {
err = ormer.Engine.DropTables(permission.Adapter)
if err != nil {
return false, err
}
}
}
// if permission.Adapter != "" && permission.Adapter != "permission_rule" {
// isEmpty, _ := ormer.Engine.IsTableEmpty(permission.Adapter)
// if isEmpty {
// err = ormer.Engine.DropTables(permission.Adapter)
// if err != nil {
// return false, err
// }
// }
// }
}
return affected, nil