feat: don't drop empty table for adapters (#3043)

* fix: solve the problem of update operation returning 'unaffected'

* feat: remove the action for Dropping empty adapter data table
This commit is contained in:
赵尧鹏
2024-07-09 11:35:22 +08:00
committed by GitHub
parent 52cc2e4fa7
commit cad2e1bcc3

View File

@ -181,15 +181,15 @@ func UpdatePermission(id string, permission *Permission) (bool, error) {
return false, err return false, err
} }
if oldPermission.Adapter != "" && oldPermission.Adapter != permission.Adapter { // if oldPermission.Adapter != "" && oldPermission.Adapter != permission.Adapter {
isEmpty, _ := ormer.Engine.IsTableEmpty(oldPermission.Adapter) // isEmpty, _ := ormer.Engine.IsTableEmpty(oldPermission.Adapter)
if isEmpty { // if isEmpty {
err = ormer.Engine.DropTables(oldPermission.Adapter) // err = ormer.Engine.DropTables(oldPermission.Adapter)
if err != nil { // if err != nil {
return false, err // return false, err
} // }
} // }
} // }
err = addGroupingPolicies(permission) err = addGroupingPolicies(permission)
if err != nil { if err != nil {
@ -312,15 +312,15 @@ func DeletePermission(permission *Permission) (bool, error) {
return false, err return false, err
} }
if permission.Adapter != "" && permission.Adapter != "permission_rule" { // if permission.Adapter != "" && permission.Adapter != "permission_rule" {
isEmpty, _ := ormer.Engine.IsTableEmpty(permission.Adapter) // isEmpty, _ := ormer.Engine.IsTableEmpty(permission.Adapter)
if isEmpty { // if isEmpty {
err = ormer.Engine.DropTables(permission.Adapter) // err = ormer.Engine.DropTables(permission.Adapter)
if err != nil { // if err != nil {
return false, err // return false, err
} // }
} // }
} // }
} }
return affected, nil return affected, nil